Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commas being treated as using directives value separators & deprecate using them with whitespace #3333

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 28, 2024

Fixes #3282

The fix itself is contained in the using_directives bump to 1.1.2:

Specifically, it's this change:

What this PR does:

  • bumps using_directives to 1.1.2
  • adds tests ensuring the old syntax is no older honored (no longer can use commas on their own as value separators)
  • adds tests for the deprecation of using commas with whitespace as value separators
  • updates the syntax in docs, old code & tests (which contributes the most to the change line count)

@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch 3 times, most recently from 0fa4c34 to 1ae6722 Compare November 29, 2024 13:53
@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch from 358244a to 1595b20 Compare December 2, 2024 14:18
@Gedochao Gedochao changed the title Update using_directives to 1.1.2 Fix commas being treated as using directives value separators & deprecate using them with whitespace Dec 2, 2024
@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch from 1595b20 to 5b8ffbd Compare December 3, 2024 10:06
…e separators on their own, and being deprecated otherwise
- get rid of unnecessary commas and double quote escapes
- bump versions where applicable
- misc typo fixes & tweaks
…: get rid of unnecessary commas and double quote escapes
@Gedochao Gedochao force-pushed the update/using_directives-1.1.2 branch from 5b8ffbd to fc6f1c1 Compare December 3, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commas shouldn't be interpreted as directive value separators on their own
1 participant